scx_lavd: Fix array index mismatch in test_cpu_stickable() #2886
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an index typo in test_cpu_stickable(). When storing the alternate domain ID for non-matching CPUs, the code incorrectly uses ctx->i_m instead of ctx->i_nm: ctx->cpdoms_not_match[ctx->i_m] = cpuc->cpdom_alt_id; // Typo ctx->cpus_not_match[ctx->i_nm] = cpu; This typo may cause array desynchronization and overwritten data. While find_sticky_cpu_and_cpdom() relies on these arrays to finalize optimal sticky domains for tasks, the bug could lead to wrong sticky domain decisions. Fixes: e064ecf ("scx_lavd: Make the idle CPU selection compute domain aware.") Signed-off-by: Gavin Guo <gavinguo@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an index typo in test_cpu_stickable(). When storing the alternate domain ID for non-matching CPUs, the code incorrectly uses ctx->i_m instead of ctx->i_nm:
ctx->cpdoms_not_match[ctx->i_m] = cpuc->cpdom_alt_id; // Typo
ctx->cpus_not_match[ctx->i_nm] = cpu;
This typo may cause array desynchronization and overwritten data. While find_sticky_cpu_and_cpdom() relies on these arrays to finalize optimal sticky domains for tasks, the bug could lead to wrong sticky domain decisions.
Fixes: e064ecf ("scx_lavd: Make the idle CPU selection compute domain aware.")