Skip to content

fix for #37 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fgeistert wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix for #37 #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/Loaf/Presenter/Controller.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ final class Controller: UIPresentationController {
containerInsets = UIEdgeInsets(top: min(statusBarSize.width, statusBarSize.height), left: 0, bottom: 0, right: 0)
}

if let tabBar = loaf.sender?.parent as? UITabBarController{
if let tabBar = loaf.sender?.parent as? UITabBarController {
containerInsets.bottom += tabBar.tabBar.frame.height
} else if let tabBar = loaf.sender?.parent?.parent as? UITabBarController {
Copy link
Owner

@schmidyy schmidyy May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should also check if the loaf.sender?.parent is a UINavigationController here, because I worry that the "parent's parent" might be a screen that is hidden from the current view. How does this look?

Suggested change
} else if let tabBar = loaf.sender?.parent?.parent as? UITabBarController {
} else if let navController = loaf.sender?.parent as? UINavigationController, let tabBar = navController.parent as? UITabBarController {

containerInsets.bottom += tabBar.tabBar.frame.height
}

Expand Down