making IconAlignment property to define without making custom style#6
Open
iAmrSalman wants to merge 4 commits intoschmidyy:masterfrom
Open
making IconAlignment property to define without making custom style#6iAmrSalman wants to merge 4 commits intoschmidyy:masterfrom
iAmrSalman wants to merge 4 commits intoschmidyy:masterfrom
Conversation
Owner
|
Interesting proposal. I'm curious how many people would prefer having the icon on the right and still use one of the default styles. Thanks for the PR! I'll think about this |
Author
|
This will be useful for right to left languages to use default styles and be able to place the icon on the right |
schmidyy
reviewed
Mar 7, 2019
| public enum IconAlignment { | ||
| case left | ||
| case right | ||
| } |
Owner
There was a problem hiding this comment.
We need to also removed the iconAlignment property from this struct too 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.