Converted to Python 3, and added a function#8
Open
idoerg wants to merge 3 commits intoscholrly:masterfrom
Open
Converted to Python 3, and added a function#8idoerg wants to merge 3 commits intoscholrly:masterfrom
idoerg wants to merge 3 commits intoscholrly:masterfrom
Conversation
wecacuee
approved these changes
Mar 8, 2022
wecacuee
left a comment
wecacuee
left a comment
There was a problem hiding this comment.
The changes look good to me.
I tested idoerg:master on Ubunut 20.04 with python3.8.
lxml needs to be added in the list of dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I converted init.py to Python 3 and added a function publ_search for searching using keywords in publications. Added documentation to the README.