Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The raw_data/kspace orientation is based on the channel assignment for RO, PE1 and PE2 gradients of the PyPulseq sequence. This information is written to the MRD file, such that during later image reconstruction, the image can be properly saved to DICOM or Nifti using the correct orientation.
A remaining issue might be that the implemented mapping from console channel to physical orientation depends on the cabling of the console and can vary between different setups. One could add the "console-channel - physical gradient" mapping to the system configuration "system_info" in
nexus-console/src/console/interfaces/acquisition_data.py
Line 177 in 4d84571
Also note that the proposed change adds a new parameter to
write_acquisition_to_mrdwhy the tests currently fail.