Added pre- and post-sampling dependent on ADC dead time#149
Open
Added pre- and post-sampling dependent on ADC dead time#149
Conversation
…d slice to discard samples
…red as sampling time, number of discard samples is passed to RxData
ckolbPTB
reviewed
Feb 3, 2026
…oor to get discard samples
ckolbPTB
approved these changes
Feb 4, 2026
Collaborator
ckolbPTB
left a comment
There was a problem hiding this comment.
Maybe specify the delay in the sequence_tests to avoid the warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, the console does not sample data during ADC delay and dead time. The dead time symmetrically adds time at the beginning and the end of an ADC event, but the ADC gate signal is off during that time.
This PR changes the interpretation of the ADC dead time in the sense, that the dead time is now considered as sampling time. The number of extra samples acquired before and after the true ADC event is stored in
RxData.Note that the dead time samples are added as a multiple of the adc dwell time defined in an ADC block:
This means:
The
RxDatainstance of an ADC event keeps all the acquired samples (in the unprocessed data and in the processed data) so the truncation of pre and post samples needs to be done by post-processing.The number of pre and post samples to be discarded is written to the acquisition header of the generated ISMRMRD file, to be considered during reconstruction.