Update bigvolumeviewer: 0.3.4 -> 0.4.1 #294
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/fiji-friends-weekly-dev-update-thread/103718/101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs a bit of testing.
The new
bigvolumeviewer-0.4.1version added support for 8bit cached multi-resolution volumes (it was only 16bit before). Code changes are in this branch and relevant discussion is in bigdataviewer/bigvolumeviewer-core#16 and bigdataviewer/bigvolumeviewer-core#25.I suspect that this will break SciView, (via scenery). But probably it would be good to have this 8-bit support also for SciView, anyway. I suspect breakage because the shaders changed and there are new uniforms. scenery uses custom shaders, I think? So these would need to be updated, too.
I don't have time to dig into it myself at the moment... Is anyone interested in pushing this forward? @NicoKiaru @ekatrukha @kephale @skalarproduktraum