Add a test for generating meta.yaml by entering input values to cookiecutter.
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
commented
Jun 25, 2025
Contributor
Author
bobleesj
left a comment
bobleesj
left a comment
There was a problem hiding this comment.
@sbillinge this is ready for review
cc' @ycexiao since you are writing unit tests for skm, just sharing a PR here for your reference.
Contributor
Author
There was a problem hiding this comment.
The test function expects to generate this meta.yaml
| hooks: | ||
| - id: check-yaml | ||
| exclude: "{{ cookiecutter.package_import_name }}/meta.yaml" | ||
| exclude: ^.*meta\.yaml$ |
Contributor
Author
There was a problem hiding this comment.
ignore all meta.yml because it always contains {{ }} jinja variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Closes #42 - add unit test for generating
meta.yamlCloses #44 - add
test-on-prCIWrote a simple test for running cookiecutter.
What should the reviewer(s) do?
Please review the unit test.