Skip to content

feat: allow scikit-package-conda-forge to automatically create the project-level cookiecutter.json #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbillinge merged 3 commits into from
Jul 2, 2025
Merged

feat: allow scikit-package-conda-forge to automatically create the project-level cookiecutter.json #47

sbillinge merged 3 commits into from
Jul 2, 2025

Conversation

@ycexiao
Copy link
Contributor

@ycexiao ycexiao commented Jun 30, 2025

What problem does this PR address?

Closes #46

What should the reviewer(s) do?

Please check the modifications.

  • This PR introduces a public-facing change (e.g., figures, CLI input/output, API).
    • Documentation (e.g., tutorials, examples, README) has been updated.
    • A tracking issue or plan to update documentation exists.
  • This PR affects internal functionality only (no user-facing change).

@ycexiao
Copy link
Contributor Author

ycexiao commented Jun 30, 2025

@sbillinge @bobleesj , it's ready for review.

bobleesj
bobleesj reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@bobleesj bobleesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ycexiao one comment - please adjust the news quote style in other PRs too

news/proj-config-in-template.rst Outdated
@@ -0,0 +1,23 @@
**Added:**

* Add `cookiecutter.json` in the template to allow `scikit-package-conda-forge` to automatically create the project-level config.
Copy link
Contributor

@bobleesj bobleesj Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use `` instead of ` for writing news since CHANGELOG is written in .rst
Screenshot 2025-07-01 at 1 39 41 PM

@sbillinge
Copy link
Collaborator

sbillinge commented Jul 1, 2025

This looks good. Please paste screenshots of it working as the best way to ensure that there are not typos etc....

@ycexiao
Copy link
Contributor Author

ycexiao commented Jul 1, 2025

@sbillinge @bobleesj
Run package create conda-forge, set project_short_description to another value.
image
diffpy.pdfgui is generated:

scikit-package-feedstock
├── ...
├── diffpy.pdfgui
│   ├── cookiecutter.json
│   └── meta.yaml

Copy the cookiecutter.json from the generated directory diffpy.pdfgui to scikit-package-feedstock and run package create conda-forge again. The project_short_description is changed.
image

@bobleesj
Copy link
Contributor

bobleesj commented Jul 1, 2025

Looking good. Thanks for testing @ycexiao

@sbillinge sbillinge merged commit 49bdd78 into scikit-package:main Jul 2, 2025
3 checks passed
@sbillinge
Copy link
Collaborator

sbillinge commented Jul 2, 2025

thanks @ycexiao

@ycexiao ycexiao mentioned this pull request Jul 2, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobleesj bobleesj bobleesj left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: add project-level cookiecutter.json in {{ cookiecutter.package_import_name}}

3 participants

@ycexiao @sbillinge @bobleesj