Skip to content

Conversation

@ycexiao
Copy link
Contributor

@ycexiao ycexiao commented Jun 30, 2025

What problem does this PR address?

Closes #16

What should the reviewer(s) do?

Please check the modifications.

  • This PR introduces a public-facing change (e.g., figures, CLI input/output, API).
    • Documentation (e.g., tutorials, examples, README) has been updated.
    • A tracking issue or plan to update documentation exists.
  • This PR affects internal functionality only (no user-facing change).

@ycexiao
Copy link
Contributor Author

ycexiao commented Jun 30, 2025

@sbillinge @bobleesj , it's ready for review.

@sbillinge
Copy link
Contributor

as in the other PR, pleaes paste screenshots of it working. Thanks.

@ycexiao
Copy link
Contributor Author

ycexiao commented Jul 1, 2025

@sbillinge
Run package create workspace in a path without cookiecutter.json:
image

cookiecutter is created in the generated directory foo.

.
├── foo
│   ├── cookiecutter.json
│   ├── ...
└── ...

Run package create workspace inside foo directory:
image

@bobleesj
Copy link
Collaborator

bobleesj commented Jul 1, 2025

@ycexiao Looks good to me!

@sbillinge sbillinge merged commit 8ce10ad into scikit-package:main Jul 2, 2025
2 checks passed
@ycexiao ycexiao mentioned this pull request Jul 2, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add cookiecutter.json in {{ cookiecutter.folder_name }}

3 participants