Adding script to restride data and bvecs#1254
Merged
arnaudbore merged 18 commits intoscilus:masterfrom Oct 31, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (72.54%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1254 +/- ##
==========================================
+ Coverage 72.46% 72.54% +0.08%
==========================================
Files 293 294 +1
Lines 25191 25291 +100
Branches 3526 3538 +12
==========================================
+ Hits 18254 18348 +94
- Misses 5445 5448 +3
- Partials 1492 1495 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
frheault
reviewed
Oct 9, 2025
arnaudbore
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick description
This is a script to validate if data has the "correct" strides 1,2,3. If not, it applies the correct transformation to get it to 1,2,3. If bvecs are given (in the case of DWI), the script will also apply the transformation on them, assuming the bvecs are in the right space. If it's not the case, the option
--validate_bveccan be used to ensure the bvecs are in the right space to begin with, and then apply the right transformation to bring them to 1,2,3 along with the data.I wonder if
--validate_bvecshould be the default option. Thought? @frheault @arnaudbore @mdesco