Skip to content

Adding script to restride data and bvecs#1254

Merged
arnaudbore merged 18 commits intoscilus:masterfrom
karanphil:restride_data
Oct 31, 2025
Merged

Adding script to restride data and bvecs#1254
arnaudbore merged 18 commits intoscilus:masterfrom
karanphil:restride_data

Conversation

@karanphil
Copy link
Contributor

Quick description

This is a script to validate if data has the "correct" strides 1,2,3. If not, it applies the correct transformation to get it to 1,2,3. If bvecs are given (in the case of DWI), the script will also apply the transformation on them, assuming the bvecs are in the right space. If it's not the case, the option --validate_bvec can be used to ensure the bvecs are in the right space to begin with, and then apply the right transformation to bring them to 1,2,3 along with the data.

I wonder if --validate_bvec should be the default option. Thought? @frheault @arnaudbore @mdesco

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 93.80531% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.54%. Comparing base (9d47098) to head (90968e3).
⚠️ Report is 54 commits behind head on master.

❌ Your project status has failed because the head coverage (72.54%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
+ Coverage   72.46%   72.54%   +0.08%     
==========================================
  Files         293      294       +1     
  Lines       25191    25291     +100     
  Branches     3526     3538      +12     
==========================================
+ Hits        18254    18348      +94     
- Misses       5445     5448       +3     
- Partials     1492     1495       +3     
Flag Coverage Δ
smoketests 69.73% <93.80%> (+0.09%) ⬆️
unittests 13.10% <10.61%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.38% <92.94%> (+0.08%) ⬆️
Library 69.17% <96.42%> (+0.07%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arnaudbore arnaudbore requested a review from frheault October 30, 2025 18:38
@arnaudbore arnaudbore added this pull request to the merge queue Oct 31, 2025
Merged via the queue into scilus:master with commit 3d5c7d0 Oct 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants