Skip to content

[ENH] New RAP method to switch params#1305

Open
arnaudbore wants to merge 20 commits intoscilus:masterfrom
arnaudbore:new_rap
Open

[ENH] New RAP method to switch params#1305
arnaudbore wants to merge 20 commits intoscilus:masterfrom
arnaudbore:new_rap

Conversation

@arnaudbore
Copy link
Contributor

Quick description

So far it can change params such as theta and step.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 26.47059% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.57%. Comparing base (eb17361) to head (b3b849e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1305      +/-   ##
==========================================
- Coverage   72.73%   72.57%   -0.16%     
==========================================
  Files         295      295              
  Lines       25445    25509      +64     
  Branches     3565     3575      +10     
==========================================
+ Hits        18507    18514       +7     
- Misses       5436     5485      +49     
- Partials     1502     1510       +8     
Flag Coverage Δ
smoketests 69.58% <26.47%> (-0.14%) ⬇️
unittests 13.79% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.34% <27.27%> (-0.04%) ⬇️
Library 69.28% <26.31%> (-0.28%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arnaudbore arnaudbore requested a review from gabknight March 4, 2026 19:15
@arnaudbore arnaudbore changed the title [WIP][ENH] New RAP method to switch params [ENH] New RAP method to switch params Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant