Reorientation to Canonical RAS with gradient support#1310
Open
frheault wants to merge 9 commits intoscilus:dev_3.0.xfrom
Open
Reorientation to Canonical RAS with gradient support#1310frheault wants to merge 9 commits intoscilus:dev_3.0.xfrom
frheault wants to merge 9 commits intoscilus:dev_3.0.xfrom
Conversation
Member
Author
|
@arnaudbore Are the tests running normally? Or should I do something to trigger them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick description
This PR is the second part of the StatefulImage transition to fully support default orientation to RAS to increase interoperalibity with mrtrix.
Here is testing data:
https://drive.google.com/file/d/1jsyiL1w9jkFvovOJ7f2AUWT1ifiNl81r/view?usp=sharing
Overall the idea is that either your bvecs and your DWI are already compatible now you can load them together and it internally flip/swap axes to canonical RAS orientation for fitting, modelling and tracking. So this is a minimal set of modifications to have a good idea if the sequence of steps is working.
If your bvecs are an orientation problem, I have now changed the scil_gradients_validate_correct script to reorient your bvecs to fit the DWI in any strides (or voxel order) and be ready for DTI or FODF fit. Extensions to future scripts, such as msmt, COMMIT, fixels or others, will be done later as it requires more thinking and this PR is big enough by itself.
This breaks previously processed DTI, evecs, FOD and peaks. But it does works much better with mrtrix and avoid manual change to 1,2,3 stride.
...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist