Adding keyword to be used with volume_stats_in_labels#1312
Adding keyword to be used with volume_stats_in_labels#1312EliseCos wants to merge 4 commits intoscilus:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1312 +/- ##
==========================================
+ Coverage 72.72% 72.87% +0.15%
==========================================
Files 295 295
Lines 25445 25471 +26
Branches 3565 3574 +9
==========================================
+ Hits 18505 18563 +58
+ Misses 5437 5403 -34
- Partials 1503 1505 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
arnaudbore
left a comment
There was a problem hiding this comment.
LGTM - @frheault do you think we would need an option to get all optional_keys ?
|
In what situation does this happen? What is the use-case this covers? I would need a bit more context @EliseCos |
|
Actually the script only merges |
| p.add_argument('--no_sort_subs', action='store_false', | ||
| help='If set, subjects won\'t be sorted alphabetically.') | ||
|
|
||
| p.add_argument('--extra_key', nargs='+', default=[], |
There was a problem hiding this comment.
'Optional keys to export (must be associated to numeric values only).'
| for m_stat in bundle_dict.values(): | ||
| if isinstance(m_stat, dict): | ||
| found_keys.update(m_stat.keys()) | ||
| keys_present = set(optional_keys) & found_keys |
There was a problem hiding this comment.
Maybe the intersection would be clearer in the future with set1.intersection(set2)
(Or leave a comment to say it is an intersection operation
Quick description
I added the subkeys from scil_volume_stats_in_labels. These keywords are optional and the script can still be used when you only have mean and std
...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist