Skip to content

Fix the streamline_id wrong size, harmonize double quote#1315

Queued
frheault wants to merge 1 commit intoscilus:masterfrom
frheault:fix_bundle_seg_empty_ids
Queued

Fix the streamline_id wrong size, harmonize double quote#1315
frheault wants to merge 1 commit intoscilus:masterfrom
frheault:fix_bundle_seg_empty_ids

Conversation

@frheault
Copy link
Member

@frheault frheault commented Mar 5, 2026

Quick description

Errors due to empty bundles when they are present in the second tractogram provided to the CLI.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

scores = bundles_wise_score[bundle_id,
streamlines_id].flatten()

results_dict[basename] = {"indices": streamlines_id.tolist(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where the important change is.

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.91%. Comparing base (b604b99) to head (d3a2f03).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
- Coverage   72.91%   72.91%   -0.01%     
==========================================
  Files         295      295              
  Lines       25453    25451       -2     
  Branches     3567     3567              
==========================================
- Hits        18560    18557       -3     
  Misses       5389     5389              
- Partials     1504     1505       +1     
Flag Coverage Δ
smoketests 69.74% <77.27%> (-0.01%) ⬇️
unittests 14.28% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.44% <ø> (+<0.01%) ⬆️
Library 69.88% <77.27%> (-0.03%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arnaudbore arnaudbore added this pull request to the merge queue Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants