Fix the streamline_id wrong size, harmonize double quote#1315
Queued
frheault wants to merge 1 commit intoscilus:masterfrom
Queued
Fix the streamline_id wrong size, harmonize double quote#1315frheault wants to merge 1 commit intoscilus:masterfrom
frheault wants to merge 1 commit intoscilus:masterfrom
Conversation
frheault
commented
Mar 5, 2026
| scores = bundles_wise_score[bundle_id, | ||
| streamlines_id].flatten() | ||
|
|
||
| results_dict[basename] = {"indices": streamlines_id.tolist(), |
Member
Author
There was a problem hiding this comment.
This is where the important change is.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1315 +/- ##
==========================================
- Coverage 72.91% 72.91% -0.01%
==========================================
Files 295 295
Lines 25453 25451 -2
Branches 3567 3567
==========================================
- Hits 18560 18557 -3
Misses 5389 5389
- Partials 1504 1505 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
arnaudbore
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick description
Errors due to empty bundles when they are present in the second tractogram provided to the CLI.
...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist