Draft
Conversation
The built-in regex engine for Python supports backtracking which can lead to backtracking DoS (since user input is used for pings). `re2` aims to fix this by reimplementing how the regex DFA is traversed and does not allow more complex regex syntax like lookahead/lookbehind, generalized assertions, and \Z. Not only does `re2` protect against backtracking algorithms, it also has a significant performance improvement compared to `re`. See https://github.com/google/re2/wiki/Syntax for more information on supported syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reworks
/pingto be more intuitivere2being used as the backendre2follows the basic regex principles (i.e. ability to represent the regex as a DFA/NFA) and does not support the more complex features (ironically making it no longer a subset of regex according to Language and Grammar Theory), which cause backtracking./ping list/ping removeautocompletes with available pings/ping removecan be removed by index as displayed by/ping list/ping removeif no other param is specifiedChecks
blackover the code to ensure formatting.Important Info
pipdependencies.Issues Closed
My pull request closes the following issues:
N/A
Thank You
Thank you for your contribution to Scioly.org! This pull request will be reviewed
in a promptly manner. If not done, please feel free to contact @cbrxyz.