Speed up implementation indexing with bitmask pre-filtering#234
Merged
Conversation
Add three fast filters before the expensive types.Implements call in findImplementations, inspired by gopls's methodsets package: 1. Unexported method package check — interfaces with unexported methods can only be implemented by types in the same package. 2. Method count check — O(1) rejection when the type has fewer methods than the interface requires. 3. 64-bit bitmask subset check — each method's signature is hashed (CRC32 of Id + fingerprint) into one bit of a uint64; a single bitwise AND rejects most non-matching pairs. The fingerprint encoding is a verbatim copy of gopls's internal/util/fingerprint package (BSD-3 licensed), which produces canonical type strings that are identical for identical types regardless of parameter names. A sync.sh script keeps the copy pinned to the golang.org/x/tools version in go.mod. Also add progress reporting (live counter) to the implementation indexing phase.
Verify that the vendored fingerprint.go stays in sync with the golang.org/x/tools version declared in go.mod.
dockerTools.buildLayeredImage is not supported on Darwin, so only expose the docker package on Linux systems. Also fix goimports alignment in ImplDef struct fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three fast filters before the expensive
types.Implementscall infindImplementations, inspired by gopls's methodsets package:The fingerprint encoding is a verbatim copy of gopls's
internal/util/fingerprintpackage, which produces canonical type strings that are identical for identical types regardless of parameter names. A sync.sh script keeps the copy pinned to the golang.org/x/tools version in go.mod.Also add progress reporting (live counter) to the implementation indexing phase.