Skip to content

Remove unused pkgLookup from fileVisitor #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jupblb merged 1 commit into from
Apr 22, 2026
+0 −7
Merged

Remove unused pkgLookup from fileVisitor #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion internal/index/scip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ func Index(writer func(proto.Message) error, opts config.IndexOpts) error {
doc,
pkg,
file,
allPackages,
pkgSymbols,
globalSymbols,
)
Expand Down
6 changes: 0 additions & 6 deletions internal/visitors/visitor_file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"log/slog"

"github.com/scip-code/scip-go/internal/document"
"github.com/scip-code/scip-go/internal/loader"
"github.com/scip-code/scip-go/internal/lookup"
"github.com/scip-code/scip-go/internal/newtypes"
"github.com/scip-code/scip-go/internal/symbols"
Expand All @@ -20,7 +19,6 @@ func NewFileVisitor(
doc *document.Document,
pkg *packages.Package,
file *ast.File,
pkgLookup loader.PackageLookup,
pkgSymbols *lookup.Package,
globalSymbols *lookup.Global,
) *fileVisitor {
Expand All @@ -40,7 +38,6 @@ func NewFileVisitor(
doc: doc,
pkg: pkg,
file: file,
pkgLookup: pkgLookup,
locals: map[token.Pos]lookup.Local{},
pkgSymbols: pkgSymbols,
globalSymbols: globalSymbols,
Expand All @@ -61,9 +58,6 @@ type fileVisitor struct {
pkg *packages.Package
file *ast.File

// soething
pkgLookup loader.PackageLookup

// local definition position to symbol and its type information
locals map[token.Pos]lookup.Local

Expand Down
Loading