Skip to content

add shared lib build to workflow; fix DLL build #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svigerske merged 2 commits into from
Dec 13, 2025
Merged

add shared lib build to workflow; fix DLL build #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23ab534
add sharedlib=on/off as additional dimension to matrix
svigerske Dec 11, 2025
4385d1c
export all symbols on windows for DLL build
svigerske Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@ on:

jobs:
build:
name: ${{ matrix.runner }} - ${{ matrix.buildtype }} - ${{ github.event_name }}
name: ${{ matrix.runner }} - ${{ matrix.buildtype }} - shared${{ matrix.sharedlib }} - ${{ github.event_name }}
runs-on: ${{ matrix.runner }}
strategy:
matrix:
runner: [ubuntu-latest, ubuntu-24.04-arm, macos-15-intel, macos-latest, windows-latest, windows-11-arm]
buildtype: [debug, release]
sharedlib: [on, off]
steps:
- uses: actions/checkout@v2
- name: Create Build Environment
Expand All @@ -22,7 +23,7 @@ jobs:
- name: Configure CMake
shell: bash
working-directory: ${{runner.workspace}}/build
run: cmake $GITHUB_WORKSPACE -DCMAKE_BUILD_TYPE=${{matrix.buildtype}}
run: cmake $GITHUB_WORKSPACE -DCMAKE_BUILD_TYPE=${{matrix.buildtype}} -DBUILD_SHARED_LIBS=${{matrix.sharedlib}}

- name: Build
working-directory: ${{runner.workspace}}/build
Expand Down
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ set_target_properties(libbliss PROPERTIES
# We cannot do this currently, because the code does not ensure that the API is made visible / exported
#CXX_VISIBILITY_PRESET hidden
#VISIBILITY_INLINES_HIDDEN ON
# But for Windows, we can ensure that all symbols are exported, which is anyway necessary when building a DLL
WINDOWS_EXPORT_ALL_SYMBOLS 1
)

add_executable(bliss src/bliss.cc)
Expand Down