Skip to content

Conversation

@jl-wynen
Copy link
Member

Bifrost does not actually have a frame monitor 0. But it does have a PSD monitor. This PR adjusts the domain types and names accordingly. Unfortunately, the current simulation files don't reflect this. But we don't use the monitors currently anyway.

But this should fix an nightly test, see https://git.esss.dk/dmsc-nightly/dmsc-nightly/-/issues/50 and https://git.esss.dk/dmsc-nightly/dmsc-nightly/-/merge_requests/153

@jl-wynen jl-wynen requested a review from g5t October 17, 2025 08:09
Copy link
Member

@SimonHeybrock SimonHeybrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (slightly older) file I have has 2 PSD monitors. Do we need PsdMonitor 1 and 2 (or actually 0 and 1 given the naming in the file)?

@jl-wynen
Copy link
Member Author

The (slightly older) file I have has 2 PSD monitors. Do we need PsdMonitor 1 and 2 (or actually 0 and 1 given the naming in the file)?

What file is that? The coda files only have psd0.

I can add a 0 to the name if you think that makes it clearer.

@SimonHeybrock
Copy link
Member

The (slightly older) file I have has 2 PSD monitors. Do we need PsdMonitor 1 and 2 (or actually 0 and 1 given the naming in the file)?

What file is that? The coda files only have psd0.

Some older simulation from Greg?

I can add a 0 to the name if you think that makes it clearer.

I think it would make sense anyway: Doesn't "PSD" just say what kind of monitor it is, but not which instance (even if there is only one)?

@g5t
Copy link
Collaborator

g5t commented Oct 17, 2025

Bifrost does not actually have a frame monitor 0. But it does have a PSD monitor.

😞 The files produced in the nightly tests are not indicative of the real instrument.

BIFROST has four monitors (plus the post-sample Bragg diffraction 'monitor'). The primary-spectrometer beam monitors are represented in my simulations as the four frame_* entries. The first was removed from the NeXus Structure used by coda. The psd0 entry is a McStas approximation to one operation mode of the fourth monitor.

BIFROST monitor location McStas component(s) Coda name
after pulse-shaping choppers frame_0 (missing)
between frame_overlap choppers frame_1 NNN_frame_1
after bandwidth choppers frame_2 NNN_frame_2
at end of guide frame_3 and psd_0 NNN_frame_3 and NNN_psd_0?
next to analyzers outside of the vacuum tank (missing) (missing)

There is an active attempt to correct the NeXus Structure to ensure it matches reality.

@jl-wynen
Copy link
Member Author

We use the Bragg peak monitor differently, so I would not include it in MonitorType.

Do you want to call them FrameMonitor{1..3}? Then I can simply remove the psd monitor in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants