This repository was archived by the owner on Jun 28, 2023. It is now read-only.
Added NewWithArgs to allow starting of the appium service with arguments#209
Open
Bradbev wants to merge 1 commit intosclevine:masterfrom
Open
Added NewWithArgs to allow starting of the appium service with arguments#209Bradbev wants to merge 1 commit intosclevine:masterfrom
Bradbev wants to merge 1 commit intosclevine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My target use-case is starting the appium service with "--relaxed-security". The other approach I considered was to allow more directly creating the appium.WebDriver struct so clients could provide an existing agouti.WebDriver.
Hopefully this PR is in an acceptable form - I've not done this often :)