Skip to content

Allow NPM_TOKEN for downloading package from private repositories. #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
phracek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow NPM_TOKEN for downloading package from private repositories. #524

phracek wants to merge 1 commit into from

Conversation

@phracek
Copy link
Member

@phracek phracek commented Jan 19, 2026 •
edited by github-actions bot
Loading

Add support NPM_TOKEN for successfully downloading

npm packages from private NPM repositories.

The pull request also contains test suite as for
BASH as for PyThon.

See Jira issue: https://issues.redhat.com/browse/RHEL-113826

@phracek
Copy link
Member Author

phracek commented Jan 19, 2026

[test][test-pytest]

@phracek phracek requested review from hhorak and khardix January 19, 2026 13:09
@phracek phracek requested a review from pkhartsk January 19, 2026 13:10
@github-actions
Copy link

github-actions bot commented Jan 19, 2026 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 10 - 22CentOS-Stream-10x86_64✅ passed19.01.2026 13:10:2311min 39stest pipeline
CentOS Stream 9 - PyTest - 24CentOS-Stream-9x86_64✅ passed19.01.2026 13:22:4614min 39stest pipeline
RHEL9 - FIPS Enabled - 24RHEL-9.6.0-Nightlyx86_64✅ passed19.01.2026 13:10:142h 15min 15stest pipeline
Fedora - PyTest - 20Fedora-latestx86_64✅ passed19.01.2026 16:34:0216min 38stest pipeline
RHEL10 - FIPS Enabled - 24-minimalRHEL-10-Nightlyx86_64✅ passed19.01.2026 13:10:082h 30min 3stest pipeline
RHEL10 - FIPS Enabled - 22-minimalRHEL-10-Nightlyx86_64✅ passed19.01.2026 16:34:011h 11min 47stest pipeline
RHEL10 - PyTest - 24RHEL-10-Nightlyx86_64✅ passed19.01.2026 13:10:162h 28min 49stest pipeline
RHEL10 - FIPS Enabled - 24RHEL-10-Nightlyx86_64✅ passed19.01.2026 16:34:011h 15min 13stest pipeline
RHEL9 - FIPS Enabled - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed19.01.2026 13:10:062h 34min 53stest pipeline
RHEL9 - FIPS Enabled - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed19.01.2026 13:10:062h 37min 51stest pipeline
RHEL9 - FIPS Enabled - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed19.01.2026 13:10:072h 37min 41stest pipeline
RHEL9 - FIPS Enabled - 22RHEL-9.6.0-Nightlyx86_64✅ passed19.01.2026 13:10:062h 37min 26stest pipeline
Fedora - 24Fedora-latestx86_64✅ passed19.01.2026 15:41:259min 41stest pipeline
RHEL9 - FIPS Enabled - 20RHEL-9.6.0-Nightlyx86_64✅ passed19.01.2026 13:10:072h 41min 17stest pipeline
CentOS Stream 9 - PyTest - 24-minimalCentOS-Stream-9x86_64✅ passed19.01.2026 17:08:5331min 15stest pipeline
CentOS Stream 10 - PyTest - 22CentOS-Stream-10x86_64✅ passed19.01.2026 15:48:549min 40stest pipeline
RHEL10 - Unsubscribed host - PyTest - 24-minimalRHEL-10-Nightlyx86_64✅ passed19.01.2026 16:34:101h 13min 8stest pipeline
Fedora - 20Fedora-latestx86_64✅ passed19.01.2026 15:51:4117min 3stest pipeline
Fedora - PyTest - 24-minimalFedora-latestx86_64✅ passed19.01.2026 16:04:037min 20stest pipeline
Fedora - 24-minimalFedora-latestx86_64✅ passed19.01.2026 16:34:146min 43stest pipeline
CentOS Stream 9 - 24-minimalCentOS-Stream-9x86_64✅ passed19.01.2026 16:34:1212min 40stest pipeline
CentOS Stream 10 - 24CentOS-Stream-10x86_64✅ passed19.01.2026 16:34:2612min 26stest pipeline
Fedora - PyTest - 20-minimalFedora-latestx86_64✅ passed19.01.2026 16:34:0314min 32stest pipeline
CentOS Stream 10 - 22-minimalCentOS-Stream-10x86_64✅ passed19.01.2026 16:42:349min 52stest pipeline
Fedora - 20-minimalFedora-latestx86_64✅ passed19.01.2026 16:48:487min 51stest pipeline
CentOS Stream 9 - 24CentOS-Stream-9x86_64✅ passed19.01.2026 16:52:2615min 59stest pipeline
RHEL10 - FIPS Enabled - 22RHEL-10-Nightlyx86_64✅ passed19.01.2026 16:34:031h 13min 16stest pipeline
RHEL9 - Unsubscribed host - PyTest - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed19.01.2026 16:34:091h 12min 44stest pipeline
RHEL8 - PyTest - 20RHEL-8.10.0-Nightlyx86_64✅ passed19.01.2026 16:34:021h 15min 56stest pipeline

@pkhartsk
Copy link
Contributor

pkhartsk commented Jan 19, 2026

Are all the pytests commented out only temporarily?

@phracek phracek force-pushed the support_npm_authentication branch from fdd4505 to 0d9ce4d Compare January 19, 2026 16:30
@phracek
Add support NPM_TOKEN for successfully downloading
fe8e844 
npm packages from private NPM repositories.

The pull request also contains test suite as for
BASH as for PyThon.

See Jira issue: https://issues.redhat.com/browse/RHEL-113826

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek phracek force-pushed the support_npm_authentication branch from 0d9ce4d to fe8e844 Compare January 19, 2026 16:32
@phracek
Copy link
Member Author

phracek commented Jan 19, 2026

[test][test-pytest]

@phracek
Copy link
Member Author

phracek commented Jan 19, 2026

Are all the pytests commented out only temporarily?

Error from my side during debugging. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khardix khardix khardix approved these changes

@hhorak hhorak Awaiting requested review from hhorak

@pkhartsk pkhartsk Awaiting requested review from pkhartsk

Assignees

No one assigned

Labels

enhancement P1 ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phracek @pkhartsk @khardix