onDidChange: eagerly force list fields (IntervalMaps are already strict via fromAscList)#103
Merged
onDidChange: eagerly force list fields (IntervalMaps are already strict via fromAscList)#103
Conversation
…ct via fromAscList)
LCamel
force-pushed
the
eager_onDidChange
branch
from
124b409 to
bb3efa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
希望 onDidChange 時不要 lazy 積欠
List 沒加 "!" 當場算 0 個 (一開始)
List 加 "!" 當場算 1 個 (某次 PR, 但這樣不夠)
List 加 evaluate length 當場算 n 個 (這次的 PR)
Map 在 from List 時全算了, 這次不特別改