Skip to content

Conversation

filipesmedeiros
Copy link
Contributor

Allow null Stocks

Allow `null` Stocks
@scottfr scottfr changed the title Fix m.Flow argument type Fix m.Flow argument type for TypeScript strictNullChecks Sep 20, 2025
@scottfr scottfr changed the title Fix m.Flow argument type for TypeScript strictNullChecks Fix m.Flow argument type for strictNullChecks Sep 20, 2025
@scottfr
Copy link
Owner

scottfr commented Sep 20, 2025

Thank you, for completeness could you make a similar change for Model.Link and model.Transition?

@filipesmedeiros
Copy link
Contributor Author

@scottfr I assumed those two were not possible. When can a link (or a transition) be created with null "tips"/ends?

@scottfr
Copy link
Owner

scottfr commented Sep 20, 2025

Dangling transitions can be used for various purposes in state/transition charts. (One could say there should alwayse be "entry" or "exit" states instead of allowing dangling transitions, but simulation does not do that.)

Dangling links, while not used in simulation's numerical simulation, but can be useful to communicate things qualitative/graphically. Both file formats the package has importers for -- Insight Maker's XML and ModelJSON -- support dangling links. I would like to support them for consistency.

@filipesmedeiros
Copy link
Contributor Author

Done :)

@scottfr
Copy link
Owner

scottfr commented Sep 21, 2025

Thank you Filipe!

@scottfr scottfr merged commit 12fe2bb into scottfr:main Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants