Switch NASA SRTM source to new LP DAAC cloud URL#27
Open
scottstanie wants to merge 2 commits intomasterfrom
Open
Switch NASA SRTM source to new LP DAAC cloud URL#27scottstanie wants to merge 2 commits intomasterfrom
scottstanie wants to merge 2 commits intomasterfrom
Conversation
The old e4ftl01.cr.usgs.gov/MEASURES endpoint is down. Migrate to the new data.lpdaac.earthdatacloud.nasa.gov/lp-prod-protected location, which uses a different URL structure where the tile filename appears as both a subdirectory and the file (e.g. .../SRTMGL1.003/N41W112.SRTMGL1.hgt/N41W112.SRTMGL1.hgt.zip). Closes #26 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When using --data-source NASA without explicit -o, the CLI defaulted to elevation.tif (GTiff format). But the NASA code path writes raw binary + .rsc sidecar, so GDAL couldn't open the file during EGM-to-WGS84 conversion (it expected a real GeoTIFF). Fix: force output_format to ENVI for NASA sources in the CLI, which makes the default output name elevation.dem. Also assert ENVI format in dem.main() as a safety net. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e4ftl01.cr.usgs.gov/MEASURESendpoint is down (empty/unavailable)data.lpdaac.earthdatacloud.nasa.gov/lp-prod-protected.../SRTMGL1.003/N41W112.SRTMGL1.hgt/N41W112.SRTMGL1.hgt.zip)elevation.deminstead ofelevation.tif, which causedgdal.Opento fail during EGM-to-WGS84 conversion (raw binary file with.tifextension wasn't a real GeoTIFF)Closes #26
Fixes #14
Test plan
sardem --data-source NASA --bbox ...produceselevation.demby default🤖 Generated with Claude Code