Added new eojx for appendix R rev3. Especially 028Exx.#90
Open
samqixin wants to merge 2 commits intoscottyphillips:masterfrom
Open
Added new eojx for appendix R rev3. Especially 028Exx.#90samqixin wants to merge 2 commits intoscottyphillips:masterfrom
samqixin wants to merge 2 commits intoscottyphillips:masterfrom
Conversation
* Update eojx.py added 02-8E * added DistributedGeneratorElectricEnergyMeter.py and its related parts, 028Exx * added pychonet/DistributedGeneratorElectricEnergyMeter.py, which was not included * revise version number * change version number * change version * version mod * revised 028E device and version number * revised again for 028E DistributedGeneratorElectricEnergyMeter * revised bug * revised bug? * revised again... * added lines in epc.py for 028E device entry names * ok this should do, revised 028E * reversed some changes back to default during dev * Update eojx.py to Release R rev.3 (#2) * Update eojx.py to Release R rev.3 * Add remaining EPC * just fix mistake --------- Co-authored-by: Naoki Sawada <hypweb+github@gmail.com> Co-authored-by: Dr-Herend <ihara.hypnos@gmail.com>
getting ready to PR to origin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a revision from the previous Feature/appendix r PR.
Thanks to @Dr-Herend. It contains many new eojx from appendix R rev3.
Especially device "distributed generator’s electric energy meter class" (028E), in order to dicover it successfully in HA.