fix issues related to 3D Hardware Textures slider #6859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The if statement wouldn't trigger as defined which caused the incorrect data offsets to be used. This resulted in corrupted textures and invalid memory reads.
In the case of an error tcache_set does not set it's output variables which can lead to issues with error handling. So set the those variables to sane defaults early on in case of failure.
Render targets are invalidated after tcache_flush is called so give the ability to detect that so that the render target can be recreated as required.
notimaginative
added
fix
Contributor
Author
|
Setting as draft in order to get comments on changing of the hardware texture detail slider. I believe I've accounted for all normal operations of FSO code, however that doesn't really help in the case of render targets created through scripting. As such, it may be necessary to prevent that detail slider from taking affect until a full restart of the engine. I believe that would be the preferred way of handling it for @BMagnu. Perhaps also adding a popup notice that the slider does nothing until full restart. Also these individual commits could be separated into other PRs if that's preferred for one or more of the bug fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several issues related to changing the 3D Hardware Textures detail slider:
Fix bug with mipmap based resizing of uncompressed textures that would result in texture corruption and invalid memory reads if the default slider wasn't at max level.
Prevent changing of the detail slider from affecting an active mission. A active mission will have to be restarted for the changes to take affect.
Fix various issues with handling of render targets, specifically with regards to proper cleanup and recovering from tcache being flushed during mission restart.