enhance and clean up scannable ship types #7129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goober5000
added
enhancement
Goober5000
force-pushed
the
fix_scannable_ship_types
branch
from
e65ad85 to
f775606
Compare
Goober5000
changed the title
Goober5000
added
Waiting for Stable
Goober5000
force-pushed
the
fix_scannable_ship_types
branch
from
f775606 to
8077da4
Compare
The `$Scannable` field in objecttypes.tbl controls whether a ship can be targeted by the "target unscanned ship" key. This is independent of which ship types can actually be *scanned*, which is not connected to any field in objecttypes.tbl. So, this PR renames the `$Scannable` field to `$Targetable as unscanned:` to be clearer about what it actually does, and it adds the missing counterpart `$Scannable by default:` flag to specify which ship types can actually be scanned. Note that this is only relevant for legacy scanning behavior. Mods which use `$Unify scanning behavior:` do not need either of the ship type flags.
Goober5000
force-pushed
the
fix_scannable_ship_types
branch
from
8077da4 to
32c07ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$Scannablefield in objecttypes.tbl controls whether a ship can be targeted by the "target unscanned ship" key. This is independent of which ship types can actually be scanned, which is not connected to any field in objecttypes.tbl.So, this PR renames the
$Scannablefield to$Targetable as unscanned:to be clearer about what it actually does, and it adds the missing counterpart$Scannable by default:flag to specify which ship types can actually be scanned.Note that this is only relevant for legacy scanning behavior. Mods which use
$Unify scanning behavior:do not need either of the ship type flags.Tested and works as expected.
Depends on #7130; in draft until that is merged.