Make sunglows respect detail boxes #7141
Open
+15
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookieejedi
approved these changes
Dec 10, 2025
Member
wookieejedi
left a comment
wookieejedi
left a comment
There was a problem hiding this comment.
Tested and fixes the issue we ran into in FotG. Likely the ship interiors project will also appreciate this fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Sun glows will get blocked by detailboxes, even if they are not rendered from the current eyepoint. This is quite annoying for stuff like low-poly versions of cockpits, that would then block the sun glow from all angles. This fixes that, and adds a flag to properly skip non-rendered detailboxes in raycasts.
Open to debate on whether this is 25.0 material, stuff for a future point release, or outright 26.0