This repository was archived by the owner on Sep 24, 2022. It is now read-only.
Draft
Conversation
danieltharp
reviewed
Jul 1, 2020
Contributor
danieltharp
left a comment
There was a problem hiding this comment.
Go ahead and make the relevant changes in the render class as well.
Member
Author
|
For sure, this isn't close to finished. I'm anticipating there's going to be a bunch of stuff to change on wikidot's side as well. |
Member
Author
$this->_tmpSplitSource = preg_split('/^([=]{4,})$/m', $source);Really, wikidot? The separator detection is duplicated between text_wiki and other parts of the codebase that need different sections. Listpages lliterally reads the page content looking for ==== and splits the text. I could go ahead and change what listpages is looking for, but how can I be sure that it's the only part of the codebase that does this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://scuttle.atlassian.net/browse/WDBUGS-152