Skip to content

Always record call_trace#2702

Open
emmiegit wants to merge 1 commit intodevelopfrom
full-trace
Open

Always record call_trace#2702
emmiegit wants to merge 1 commit intodevelopfrom
full-trace

Conversation

@emmiegit
Copy link
Copy Markdown
Member

As noted in discussion on #2701, the call_trace field will be retained internally only, and so it is safe to record the data even in the case of authentication issues. (This is because only developers will be reviewing the logs and it cannot be used by attackers to determine internal authentication state).

@emmiegit emmiegit self-assigned this Feb 22, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 22, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 2.28%. Comparing base (640fbbf) to head (7cc85bb).

Files with missing lines Patch % Lines
deepwell/src/error/convert.rs 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #2702   +/-   ##
=======================================
  Coverage     2.28%   2.28%           
=======================================
  Files          171     171           
  Lines        10286   10284    -2     
=======================================
  Hits           235     235           
+ Misses       10051   10049    -2     
Files with missing lines Coverage Δ
deepwell/src/error/convert.rs 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emmiegit emmiegit enabled auto-merge February 22, 2026 13:35
@Zokhoi
Copy link
Copy Markdown
Contributor

Zokhoi commented Feb 22, 2026

Hmm, I'm not familiar with the relevant code in deepwell, but I believe right now we don't have code to block showing call_trace in production, so maybe reserve this for later?

@emmiegit emmiegit disabled auto-merge February 22, 2026 13:39
@emmiegit
Copy link
Copy Markdown
Member Author

That's fine, we aren't in any rush to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants