Skip to content

NPM & no lerna test #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: devel
Choose a base branch
from
Open

NPM & no lerna test #768

wants to merge 7 commits into from

Conversation

@MichalCz
Copy link
Member

@MichalCz MichalCz commented Dec 21, 2022 •
edited by patuwwy
Loading

What?

  • Remove all lerna:
  • Remove all references to lerna
  • Opt for npm scripts
  • Fix run-script to fail if errors occur

Why?

Lerna is outdated

Review checks:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

@a-tylenda a-tylenda mentioned this pull request Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alicja-gruzdz alicja-gruzdz Awaiting requested review from alicja-gruzdz

1 more reviewer

@patuwwy patuwwy patuwwy approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichalCz @patuwwy