Test for issue with API Server path handling #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicja-gruzdz
approved these changes
Jun 5, 2023
|
Will be merged when the test passes. |
MichalCz
force-pushed
the
fix/path-handling-issue-api-server
branch
from
0126b1e to
1ca7f92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
API Server accepts paths strictly as their ASCII representation and that was the intended way, but using
+in the path breaks the route.What should be happenning is that either:
+char should be treated as a non-special caseIncluded
Why?
However this has no current impact, path handling should work consistently.
Running this test will show the issue:
Review checks:
These aspects need to be checked by the reviewer: