Open
Conversation
Removed the unnecessary constructor.
Removed unnecessary constructor
KQL1N
reviewed
Jan 23, 2017
Collaborator
KQL1N
left a comment
KQL1N
left a comment
There was a problem hiding this comment.
Have a look at that array index problem. I could be wrong if your testing if running fine, but I'm not sure how it would work okay.
| @Test | ||
| public void test() { | ||
| MedTask med = new MedTask(); | ||
| int[] newArray = new int[3]; |
Collaborator
There was a problem hiding this comment.
On your arraytests JUnit test case, you are initializing newArray to length 3, but then setting
"newArray[3] = 40;" even though [3] would be the fourth index.
| package tests; | ||
|
|
||
| public class MedTask | ||
| { |
Collaborator
There was a problem hiding this comment.
Removed an unnecessary constructor
| { | ||
| public int[] arrayReverse(int[] newArray) | ||
| { | ||
| int[] tempArray = new int[4]; |
Collaborator
There was a problem hiding this comment.
Removed an unnecessary constructor
added 2 commits
January 23, 2017 17:24
be changed between two strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.