Skip to content

Conversation

CrazyPython
Copy link

Right now to use the memory queues, we have to do this:

from queuelib.queue import FifoMemoryQueue, LifoMemoryQueue

This PR lets us do this:

from queuelib import FifoMemoryQueue, LifoMemoryQueue

This has readability gains because it means we can write:

from queuelib import FifoMemoryQueue, LifoMemoryQueue, PriorityQueue

Instead of:

from queuelib.queue import FifoMemoryQueue, LifoMemoryQueue, PriorityQueue
from queuelib.pqueue import PriorityQueue

Unless this is intentional to discourage using non-disk queues, this change should improve library ergonomics.

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2467caf) to head (7bb1179).
⚠️ Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          310       310           
  Branches        38        38           
=========================================
  Hits           310       310           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gallaecio
Copy link
Member

I wonder if we should take the chance to cover them in the README as well, for discoverability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants