Open
Conversation
…feature/mobile # Conflicts: # src/modules/Guitar/Guitar.less Add support for better rendering instruments with odd number of strings
Fix issue with guitar overflow
walmik
reviewed
Oct 7, 2020
| <div className="fretDot fretDot-bottom ninthFret"></div> | ||
| <div className="fretDot fretDot-bottom twelthFret"></div> | ||
| <div className="fretDot fretDot-bottom fifteenthFret"></div> | ||
| </div> |
Collaborator
There was a problem hiding this comment.
Are the above 2 blocks deliberately duplicated? Just trying to understand what is the reason for this. Would be nice to add a screenshot or two for the changes you re introducing.
Contributor
Author
There was a problem hiding this comment.
I couldn't think of a nicer way of handling this at the time. This handles the situation where there is an odd number of strings and offsets the fretDots
Changes this
Into this
Contributor
Author
|
Screenshots of changes below Note that in the below screenshot the fretbar is scrollable Noticed while grabbing screenshots that I'd accidentally changed landing page. Will fix this evening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to make the application, especially the guitar view, more friendly for mobile users