Updated mic no audio detection/flags #232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennettrwu
requested changes
Dec 8, 2025
| mic_stream = await navigator.mediaDevices.getUserMedia({ audio: true, video: false }); | ||
| } catch (e) { | ||
| console.error('Failed to access microphone', e); | ||
| try { store.dispatch({ type: 'SET_MIC_INACTIVITY', payload: true }); } catch (_) {} |
Contributor
There was a problem hiding this comment.
try/catch here seems unnecessary, since dispatch shouldn't throw an error when used correctly. If it is, could you put some error handling in the catch?
| // update last audio timestamp and mark that we've received at least one audio chunk | ||
| this.lastAudioTimestamp = Date.now(); | ||
| try { (window as any).__lastAudioTimestamp = this.lastAudioTimestamp; } catch (e) {} | ||
| try { (window as any).__hasReceivedAudio = true; if ((window as any).__initialAudioTimer) { clearTimeout((window as any).__initialAudioTimer); (window as any).__initialAudioTimer = null; } } catch (e) {} |
Contributor
There was a problem hiding this comment.
__lastAudioTimestamp, __hasReceivedAudio, __initialAudioTimer appear to be unused. Can we remove these setters here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulated all flag checking logic in scribearRecognizer