🐛 优化脚本图标展示 #1052 #1104
Merged
🐛 优化脚本图标展示 #1052 #1104
+21
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyfung1031
reviewed
Dec 22, 2025
| {...rest} | ||
| > | ||
| {icon && !imageError ? ( | ||
| <img title={match} src={icon} onError={() => setImageError(true)} /> |
Collaborator
There was a problem hiding this comment.
不是在 fetchIcon 已经能知道是失败还是成功吗
不然怎储在OPFS？
CodFrm
commented
Dec 24, 2025
Comment on lines
-228
to
-233
| try { | ||
| const sessionBlobUrl = await cacheInstance.get<string>(`${CACHE_KEY_FAVICON}${filename}`); | ||
| if (sessionBlobUrl) return sessionBlobUrl; | ||
| } catch { | ||
| // 即使报错也不影响 | ||
| } |
Member
Author
There was a problem hiding this comment.
@cyfung1031 这里是运行在option页面上的，刷新option页面，会释放掉，这里用了缓存第二次会返回无效的链接
Collaborator
There was a problem hiding this comment.
那就不cache每次都取opfs 做bloburl吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概述 Descriptions
close #1052
变更内容 Changes
截图 Screenshots