Skip to content

sumcheck skip send p0 #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hero78119 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

sumcheck skip send p0 #1247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76e1b5d
sumcheck skip send p0
hero78119 Jan 28, 2026
0b9a44b
simplify basefold verifier query phase
hero78119 Jan 28, 2026
52496ae
Merge branch 'master' into feat/skip_eval_0
hero78119 Jan 30, 2026
2d2d36a
update gkr version
hero78119 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@ version = "0.1.0"
ceno_crypto_primitives = { git = "https://github.com/scroll-tech/ceno-patch.git", package = "ceno_crypto_primitives", branch = "main" }
ceno_syscall = { git = "https://github.com/scroll-tech/ceno-patch.git", package = "ceno_syscall", branch = "main" }

ff_ext = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "ff_ext", tag = "v1.0.0-alpha.20" }
mpcs = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "mpcs", tag = "v1.0.0-alpha.20" }
multilinear_extensions = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "multilinear_extensions", tag = "v1.0.0-alpha.20" }
p3 = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "p3", tag = "v1.0.0-alpha.20" }
poseidon = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "poseidon", tag = "v1.0.0-alpha.20" }
sp1-curves = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "sp1-curves", tag = "v1.0.0-alpha.20" }
sumcheck = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "sumcheck", tag = "v1.0.0-alpha.20" }
transcript = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "transcript", tag = "v1.0.0-alpha.20" }
whir = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "whir", tag = "v1.0.0-alpha.20" }
witness = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "witness", tag = "v1.0.0-alpha.20" }
ff_ext = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "ff_ext", rev = "8ce1577d61af241606d30aefe9ac896e7502809a" }
mpcs = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "mpcs", rev = "8ce1577d61af241606d30aefe9ac896e7502809a" }
multilinear_extensions = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "multilinear_extensions", rev = "8ce1577d61af241606d30aefe9ac896e7502809a" }
p3 = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "p3", rev = "8ce1577d61af241606d30aefe9ac896e7502809a" }
poseidon = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "poseidon", rev = "8ce1577d61af241606d30aefe9ac896e7502809a" }
sp1-curves = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "sp1-curves", rev = "8ce1577d61af241606d30aefe9ac896e7502809a" }
sumcheck = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "sumcheck", rev = "8ce1577d61af241606d30aefe9ac896e7502809a" }
transcript = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "transcript", rev = "8ce1577d61af241606d30aefe9ac896e7502809a" }
whir = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "whir", rev = "8ce1577d61af241606d30aefe9ac896e7502809a" }
witness = { git = "https://github.com/scroll-tech/gkr-backend.git", package = "witness", rev = "8ce1577d61af241606d30aefe9ac896e7502809a" }

anyhow = { version = "1.0", default-features = false }
bincode = "1"
Expand Down
72 changes: 40 additions & 32 deletions ceno_recursion/src/arithmetics/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,35 +866,51 @@ impl<C: Config> UniPolyExtrapolator<C> {
}

pub fn extrapolate_uni_poly(
&mut self,
&self,
builder: &mut Builder<C>,
p_0: Ext<C::F, C::EF>,
p_i: &Array<C, Ext<C::F, C::EF>>,
eval_at: Ext<C::F, C::EF>,
) -> Ext<C::F, C::EF> {
let res: Ext<C::F, C::EF> = builder.constant(C::EF::ZERO);
let length: RVar<_> = builder.eval_expr(p_i.len() + Usize::from(1));

builder.if_eq(p_i.len(), Usize::from(4)).then_or_else(
builder.if_eq(length, Usize::from(4)).then_or_else(
|builder| {
let ext = self.extrapolate_uni_poly_deg_3(builder, p_i, eval_at);
let p_i_1: Ext<C::F, C::EF> = builder.get(p_i, 0);
let p_i_2: Ext<C::F, C::EF> = builder.get(p_i, 1);
let p_i_3: Ext<C::F, C::EF> = builder.get(p_i, 2);
let ext =
self.extrapolate_uni_poly_deg_3(builder, p_0, p_i_1, p_i_2, p_i_3, eval_at);
builder.assign(&res, ext);
},
|builder| {
builder.if_eq(p_i.len(), Usize::from(3)).then_or_else(
builder.if_eq(length, Usize::from(3)).then_or_else(
|builder| {
let ext = self.extrapolate_uni_poly_deg_2(builder, p_i, eval_at);
let p_i_1: Ext<C::F, C::EF> = builder.get(p_i, 0);
let p_i_2: Ext<C::F, C::EF> = builder.get(p_i, 1);
let ext =
self.extrapolate_uni_poly_deg_2(builder, p_0, p_i_1, p_i_2, eval_at);
builder.assign(&res, ext);
},
|builder| {
builder.if_eq(p_i.len(), Usize::from(2)).then_or_else(
builder.if_eq(length, Usize::from(2)).then_or_else(
|builder| {
let ext = self.extrapolate_uni_poly_deg_1(builder, p_i, eval_at);
let p_i_1: Ext<C::F, C::EF> = builder.get(p_i, 0);
let ext =
self.extrapolate_uni_poly_deg_1(builder, p_0, p_i_1, eval_at);
builder.assign(&res, ext);
},
|builder| {
builder.if_eq(p_i.len(), Usize::from(5)).then_or_else(
builder.if_eq(length, Usize::from(5)).then_or_else(
|builder| {
let ext =
self.extrapolate_uni_poly_deg_4(builder, p_i, eval_at);
let p_i_1: Ext<C::F, C::EF> = builder.get(p_i, 0);
let p_i_2: Ext<C::F, C::EF> = builder.get(p_i, 1);
let p_i_3: Ext<C::F, C::EF> = builder.get(p_i, 2);
let p_i_4: Ext<C::F, C::EF> = builder.get(p_i, 3);
let ext = self.extrapolate_uni_poly_deg_4(
builder, p_0, p_i_1, p_i_2, p_i_3, p_i_4, eval_at,
);
builder.assign(&res, ext);
},
|builder| {
Expand All @@ -914,7 +930,8 @@ impl<C: Config> UniPolyExtrapolator<C> {
fn extrapolate_uni_poly_deg_1(
&self,
builder: &mut Builder<C>,
p_i: &Array<C, Ext<C::F, C::EF>>,
p_i_0: Ext<C::F, C::EF>,
p_i_1: Ext<C::F, C::EF>,
eval_at: Ext<C::F, C::EF>,
) -> Ext<C::F, C::EF> {
// w0 = 1 / (0−1) = -1
Expand All @@ -923,9 +940,6 @@ impl<C: Config> UniPolyExtrapolator<C> {
let d1: Ext<C::F, C::EF> = builder.eval(eval_at - self.constants[1]);
let l: Ext<C::F, C::EF> = builder.eval(d0 * d1);

let p_i_0 = builder.get(p_i, 0);
let p_i_1 = builder.get(p_i, 1);

let t0: Ext<C::F, C::EF> = builder.eval(self.constants[5] * p_i_0 * d0.inverse());
let t1: Ext<C::F, C::EF> = builder.eval(self.constants[1] * p_i_1 * d1.inverse());

Expand All @@ -935,7 +949,9 @@ impl<C: Config> UniPolyExtrapolator<C> {
fn extrapolate_uni_poly_deg_2(
&self,
builder: &mut Builder<C>,
p_i: &Array<C, Ext<C::F, C::EF>>,
p_i_0: Ext<C::F, C::EF>,
p_i_1: Ext<C::F, C::EF>,
p_i_2: Ext<C::F, C::EF>,
eval_at: Ext<C::F, C::EF>,
) -> Ext<C::F, C::EF> {
// w0 = 1 / ((0−1)(0−2)) = 1/2
Expand All @@ -947,10 +963,6 @@ impl<C: Config> UniPolyExtrapolator<C> {

let l: Ext<C::F, C::EF> = builder.eval(d0 * d1 * d2);

let p_i_0: Ext<C::F, C::EF> = builder.get(p_i, 0);
let p_i_1: Ext<C::F, C::EF> = builder.get(p_i, 1);
let p_i_2: Ext<C::F, C::EF> = builder.get(p_i, 2);

let t0: Ext<C::F, C::EF> = builder.eval(self.constants[6] * p_i_0 * d0.inverse());
let t1: Ext<C::F, C::EF> = builder.eval(self.constants[5] * p_i_1 * d1.inverse());
let t2: Ext<C::F, C::EF> = builder.eval(self.constants[6] * p_i_2 * d2.inverse());
Expand All @@ -961,7 +973,10 @@ impl<C: Config> UniPolyExtrapolator<C> {
fn extrapolate_uni_poly_deg_3(
&self,
builder: &mut Builder<C>,
p_i: &Array<C, Ext<C::F, C::EF>>,
p_i_0: Ext<C::F, C::EF>,
p_i_1: Ext<C::F, C::EF>,
p_i_2: Ext<C::F, C::EF>,
p_i_3: Ext<C::F, C::EF>,
eval_at: Ext<C::F, C::EF>,
) -> Ext<C::F, C::EF> {
// w0 = 1 / ((0−1)(0−2)(0−3)) = -1/6
Expand All @@ -975,11 +990,6 @@ impl<C: Config> UniPolyExtrapolator<C> {

let l: Ext<C::F, C::EF> = builder.eval(d0 * d1 * d2 * d3);

let p_i_0: Ext<C::F, C::EF> = builder.get(p_i, 0);
let p_i_1: Ext<C::F, C::EF> = builder.get(p_i, 1);
let p_i_2: Ext<C::F, C::EF> = builder.get(p_i, 2);
let p_i_3: Ext<C::F, C::EF> = builder.get(p_i, 3);

let t0: Ext<C::F, C::EF> = builder.eval(self.constants[9] * p_i_0 * d0.inverse());
let t1: Ext<C::F, C::EF> = builder.eval(self.constants[6] * p_i_1 * d1.inverse());
let t2: Ext<C::F, C::EF> = builder.eval(self.constants[7] * p_i_2 * d2.inverse());
Expand All @@ -991,7 +1001,11 @@ impl<C: Config> UniPolyExtrapolator<C> {
fn extrapolate_uni_poly_deg_4(
&self,
builder: &mut Builder<C>,
p_i: &Array<C, Ext<C::F, C::EF>>,
p_i_0: Ext<C::F, C::EF>,
p_i_1: Ext<C::F, C::EF>,
p_i_2: Ext<C::F, C::EF>,
p_i_3: Ext<C::F, C::EF>,
p_i_4: Ext<C::F, C::EF>,
eval_at: Ext<C::F, C::EF>,
) -> Ext<C::F, C::EF> {
// w0 = 1 / ((0−1)(0−2)(0−3)(0−4)) = 1/24
Expand All @@ -1007,12 +1021,6 @@ impl<C: Config> UniPolyExtrapolator<C> {

let l: Ext<C::F, C::EF> = builder.eval(d0 * d1 * d2 * d3 * d4);

let p_i_0: Ext<C::F, C::EF> = builder.get(p_i, 0);
let p_i_1: Ext<C::F, C::EF> = builder.get(p_i, 1);
let p_i_2: Ext<C::F, C::EF> = builder.get(p_i, 2);
let p_i_3: Ext<C::F, C::EF> = builder.get(p_i, 3);
let p_i_4: Ext<C::F, C::EF> = builder.get(p_i, 4);

let t0: Ext<C::F, C::EF> = builder.eval(self.constants[11] * p_i_0 * d0.inverse());
let t1: Ext<C::F, C::EF> = builder.eval(self.constants[9] * p_i_1 * d1.inverse());
let t2: Ext<C::F, C::EF> = builder.eval(self.constants[10] * p_i_2 * d2.inverse());
Expand Down
Loading