[WIP] Halo2 ecc snark verifier rebase 0329: post rebase#5
Open
zhenfeizhang wants to merge 27 commits intodevelopfrom
Open
[WIP] Halo2 ecc snark verifier rebase 0329: post rebase#5zhenfeizhang wants to merge 27 commits intodevelopfrom
zhenfeizhang wants to merge 27 commits intodevelopfrom
Conversation
assignments using our basic gate * WIP: currently `gates::flex_gate` is updated and passes basic test
check that the indicator witness was equal to 1 when non-zero. * Previously the constraint ensured that `ind[i] = 0` when `idx != i` however `ind[idx]` could be anything!!!
* this function was not used anywhere
and there is a break point in that overlap * we need to copy a cell between columns to fix
* In keygen mode, the `CircuitBuilder` will clone the `ThreadBuilder` instead of `take`ing it because the same circuit is used for both vk gen and pk gen. This could lead to more memory usage for pk gen.
compatibility after halo2-base update
* add multi-thread witness assignment support for `variable_base_msm` and `fixed_base_msm` * batch size 100 MSM witness generation went from 500ms -> 100ms
* change other uses of `size_hint` to follow with `assert_eq!` instead of `debug_assert_eq!`
`bit_len < 64` and `decompose_biguint` to `64 <= bit_len < 128` * add more comprehensive tests for above two functions
* compatibility update with `halo2_proofs_axiom`
assigned cells for external equality constraints (e.g., instance cells, `AssignedCells` from chips not using halo2-lib). fix: `assign_all` was not assigning constants as desired: it was assigning a new constant per context. This leads to confusion and possible undesired consequences down the line.
as input instead of new hashmap, in case we want to constrain equalities for cells not belonging to this builder
`idx` the value could be 0 or 1 (instead of only 1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.