Skip to content

fix: block request serve signature #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

yiweichi
Copy link
Member

@yiweichi yiweichi commented Aug 17, 2025

This PR aims to fix the issue reth doesn’t include signature during block request.

We persist the signature in the extra_data field of block header, so we can serve blocks with signatures for l2geth’s block requests.

Copy link

codspeed-hq bot commented Aug 17, 2025

CodSpeed Performance Report

Merging #324 will not alter performance

Comparing fix-eth66-serve-signature (f77d6bf) with scroll (85a5d1d)

Summary

✅ 77 untouched benchmarks

@yiweichi
Copy link
Member Author

Close this, because we plan to go with solution that create a new table to persist signature.

@yiweichi yiweichi closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant