attach encryption key to msg #186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thegaram
reviewed
Sep 9, 2025
| // Check that the encryption key specified in the message represents the pubkey for the | ||
| // sequencer's decryption key. | ||
| if PublicKey::try_from_bytes(encryptionKey.as_ref())?.ne(&secret_key.public_key()) { | ||
| return Err(ValidiumError::InvalidEncryptionKey); |
There was a problem hiding this comment.
Same here, we should not treat this as InvalidEncryptionKey (user error), but instead as UnknownEncryptionKey (internal error that we need to fix).
|
Closing as the public key will no longer be attached to the L1 msg. Instead the encryption key will be a part of public inputs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.