Add smallest_dot parameter to dotplot#524
Merged
falexwolf merged 1 commit intoscverse:masterfrom Mar 11, 2019
Merged
Conversation
Allow greater customizability and visibility when using dotplot by allowing the user to set the smallest dot size.
Member
|
@fidelram, are you happy with this? If you agree, I would also just make you a maintainer of Scanpy, so that you can merge PRs related to the plotting API yourself. :) |
Collaborator
|
Thanks for this PR @sjfleming . If you don't mind I will integrate this functionality into a new PR that also covers #512 and #525 |
This was referenced Mar 11, 2019
Merged
Member
|
Merged through #528. |
Collaborator
|
Does this feature work with the latest scanpy? I don't see any change when I specify different values for the smallest_dot option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow greater customizability and visibility when using dotplot by allowing the user to set the smallest dot size. This change updates the dots along with the dot size legend.