Skip to content

Fix for FutureWarning: functools.partial ...#1076

Merged
melonora merged 1 commit intoscverse:mainfrom
selmanozleyen:fix/partial-warnings
Feb 19, 2026
Merged

Fix for FutureWarning: functools.partial ...#1076
melonora merged 1 commit intoscverse:mainfrom
selmanozleyen:fix/partial-warnings

Conversation

@selmanozleyen
Copy link
Member

@selmanozleyen selmanozleyen commented Feb 19, 2026

This is a minimal fix doing exactly what the warnings says and is backward compat. Here is an example of how the warnings look:

.venv/lib/python3.13/site-packages/spatialdata/_core/query/relational_query.py:532
  /Users/selman/projects/squidpy/.venv/lib/python3.13/site-packages/spatialdata/_core/query/relational_query.py:532: FutureWarning: functools.partial will be a method descriptor in future Python versions; wrap it in enum.member() if you want to preserve the old behavior
    left_exclusive = partial(_left_exclusive_join_spatialelement_table)

.venv/lib/python3.13/site-packages/spatialdata/_core/query/relational_query.py:533
  /Users/selman/projects/squidpy/.venv/lib/python3.13/site-packages/spatialdata/_core/query/relational_query.py:533: FutureWarning: functools.partial will be a method descriptor in future Python versions; wrap it in enum.member() if you want to preserve the old behavior
    inner = partial(_inner_join_spatialelement_table)

.venv/lib/python3.13/site-packages/spatialdata/_core/query/relational_query.py:534
  /Users/selman/projects/squidpy/.venv/lib/python3.13/site-packages/spatialdata/_core/query/relational_query.py:534: FutureWarning: functools.partial will be a method descriptor in future Python versions; wrap it in enum.member() if you want to preserve the old behavior
    right = partial(_right_join_spatialelement_table)

.venv/lib/python3.13/site-packages/spatialdata/_core/query/relational_query.py:535
  /Users/selman/projects/squidpy/.venv/lib/python3.13/site-packages/spatialdata/_core/query/relational_query.py:535: FutureWarning: functools.partial will be a method descriptor in future Python versions; wrap it in enum.member() if you want to preserve the old behavior
    right_exclusive = partial(_right_exclusive_join_spatialelement_table)

ping: @LucaMarconato

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.94%. Comparing base (cdf3435) to head (dadf411).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1076   +/-   ##
=======================================
  Coverage   91.94%   91.94%           
=======================================
  Files          51       51           
  Lines        7673     7673           
=======================================
  Hits         7055     7055           
  Misses        618      618           
Files with missing lines Coverage Δ
src/spatialdata/_core/query/relational_query.py 91.61% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@selmanozleyen selmanozleyen changed the title Fix for FutureWarning: functools.partial will be a method descriptor in future Python versions; wrap it in enum.member() Fix for FutureWarning: functools.partial ... Feb 19, 2026
@melonora melonora force-pushed the fix/partial-warnings branch from d4d35cc to dadf411 Compare February 19, 2026 12:17
@melonora
Copy link
Collaborator

Cheers, just changed the commit message to be more informative. Will merge when tests pass.

@melonora melonora merged commit bc5b2ca into scverse:main Feb 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants