Conversation
matthewruehle
left a comment
matthewruehle
left a comment
There was a problem hiding this comment.
This code isn't the cleanest - you've left in a lot of commented-out code, and some of the functions you've implemented aren't documented quite well enough to make sense at first glance. Plus, you worked on Release rather than Master - though, you mention that in your form so you already know about that.
That being said -- you certainly picked an ambitious expansion upon the project, involving web integration and additional text processing; what's more, it looks solidly done! I wish I could give you a better eval, but we're looking heavily for code quality/cleanliness on this project - MP5 was geared heavily towards cleanliness, objects, and best practices.
insertUrl.py
Outdated
| self.c.execute("INSERT INTO " + url2 + " VALUES (?,?,?)", (i, listWords[i], 'NA')) | ||
|
|
||
| # self.c.execute("INSERT INTO " + url2 + " VALUES (?,?,?)", (1, 'sample text word', 'sample text color')) | ||
| # self.c.execute("INSERT INTO " + url2 + " VALUES (?,?,?)", (2, 'sample text word', 'sample text color')) |
There was a problem hiding this comment.
Left some commented-out test code in here - not the best practices, but ah well.
insertUrl.py
Outdated
| # print(mydb.creatURLDB(url,url2,listWords)) | ||
| # print(mydb.checkVisited(url)) | ||
| # print(mydb.getWord(url2,0)) | ||
| # print(mydb.getColor(url2,0)) |
requirements.txt
Outdated
| Flask==0.12 | ||
| pronouncing==0.1.5 | ||
| beautifulsoup4 | ||
| requests==2.13.0 |
2 participants
No description provided.