Conversation
…arams - Updated the _LayerArray constructor to accept a LayerArrayParams object, simplifying parameter management and improving code readability. - Adjusted the internal logic to utilize the new params structure for layer initialization, ensuring consistency across layer configurations. - Modified relevant test files to align with the new constructor signature, maintaining comprehensive test coverage for layer array functionality.
- Refactored the _Layer constructor to accept a LayerParams struct, consolidating parameters for improved readability and maintainability. - Updated all relevant test files to utilize the new LayerParams structure, ensuring consistent layer initialization across the codebase. - Enhanced the clarity of the code by reducing the number of parameters passed directly to the _Layer constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a ton of parameters to the constructors to the wavenet layer and layer array classes. Refactor them to take a single "params" struct as the argument.