[FEATURE] WaveNet: Make layer1x1 (formerly 1x1) optional, rename .nam key "head_1x1" to "head1x1"#214
Merged
sdatkinson merged 5 commits intomainfrom Jan 29, 2026
Merged
[FEATURE] WaveNet: Make layer1x1 (formerly 1x1) optional, rename .nam key "head_1x1" to "head1x1"#214sdatkinson merged 5 commits intomainfrom
layer1x1 (formerly 1x1) optional, rename .nam key "head_1x1" to "head1x1"#214sdatkinson merged 5 commits intomainfrom
Conversation
- Introduced a new test file `test_layer1x1.cpp` to validate the behavior of the Layer1x1 component in the WaveNet architecture. - Implemented multiple test cases to check both active and inactive states of Layer1x1, ensuring correct processing of inputs and outputs. - Added validation for error handling when the bottleneck does not match channels in inactive Layer1x1 configurations. - Enhanced tests to cover scenarios with grouped Layer1x1 convolutions and post-FiLM behavior, ensuring comprehensive coverage of the new functionality.
sdatkinson
changed the title
layer1x1 (formerly 1x1) optionallayer1x1 (formerly 1x1) optional, rename .nam key "head_1x1" to "head1x1"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the 1x1 that outputs to the skip connection and next layer so that it's optional and treated similarly to
head1x1where possible.There is one constraint that its output channels must be a specific size for the skip-connection, so
out_channelsisn't a configurable hyperparameter; otherwise, things are rather similar.Also fixing an annoying inconsistency between the .nam file and the code with "head1x1".
Resolves #213 .