Open
Conversation
…ts as we modify the C++ code base. Using and fetching dynamically catch2. Auto-generating the test project with cmake. RTead HowTo.txt to get started. Adding the first c++ additional class to be tested prior to its addtion in the plugin projects named NeuralAmpModelerPreset.
|
is there any reason why this PR is not merged and still open after all this time? |
Owner
Haven't had time. Also the PR introduces multiple things (both unit testing framework and presets) that makes it harder to understand. A reworked PR that only adds unit tests would be easier to merge--I'm not sure I want presets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial UnitTesting project in order to create, build and run unit tests as we modify the C++ code base.
Using and fetching dynamically catch2 test framework.
Auto-generating the test project with cmake.
Read HowTo.txt to get started.
Adding the first C++ additional class to be tested prior to its addition in the plugin projects named NeuralAmpModelerPreset.