Closed
Conversation
- Use `plugins` instead of `require` for rubocop-performance, per the new plugin system - Rename `Naming/PredicateName` to `Naming/PredicatePrefix` to match the upstream cop rename
Contributor
Author
|
Closing — these config changes break backward compatibility with RuboCop 1.0.x, which is still in the supported version range (gemspec requires >= 1.0). The old names produce harmless deprecation warnings in newer RuboCop but the new names cause hard errors in RuboCop 1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require: rubocop-performancetoplugins: rubocop-performanceper RuboCop's new plugin systemNaming/PredicateNamecop toNaming/PredicatePrefixto match the upstream renameTest plan
bundle exec rubocopruns clean with no warnings and no offenses