Skip to content

Serve both servers with shared instance#58

Merged
Arshdeep54 merged 7 commits intorefactorfrom
server_crate
Dec 23, 2025
Merged

Serve both servers with shared instance#58
Arshdeep54 merged 7 commits intorefactorfrom
server_crate

Conversation

@4adex
Copy link
Copy Markdown
Collaborator

@4adex 4adex commented Dec 22, 2025

server crate serves both the grpc as well as http server with shared Arc<VectorDb>.
disable_http flag in configuration allows to serve only through grpc.

@4adex 4adex requested a review from Arshdeep54 December 22, 2025 17:19
@Arshdeep54
Copy link
Copy Markdown
Contributor

Box<dyn std::error::Error + Send + Sync>>
Add type aliasing for this.

Copy link
Copy Markdown
Contributor

@Arshdeep54 Arshdeep54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arshdeep54 Arshdeep54 merged commit 4cdcc3d into refactor Dec 23, 2025
2 checks passed
@4adex 4adex deleted the server_crate branch December 27, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants